feat(kubernetes): add kubernetes nodegroup show command#242
Merged
Conversation
kangasta
force-pushed
the
feat/k8s-node-group-details
branch
from
4e86234 to
5839032
Compare
peknur
approved these changes
Jul 18, 2023
Contributor
peknur
left a comment
peknur
left a comment
There was a problem hiding this comment.
Looks good 👍 Tested this locally and output looks good. Left non-blocking comment about naming convention.
| ## [Unreleased] | ||
|
|
||
| ### Added | ||
| - Add `kubernetes nodegroup show` for displaying node-group details. This also adds _Nodes_ table and _Anti-affinity_ field that were not available in previous `kubernetes show` output. |
Contributor
There was a problem hiding this comment.
Not a blocker, but just wondering would node-group be more aligned with HTTP API resource and SDK's type names 🤔
Member
Author
There was a problem hiding this comment.
Yeah, we could go trough the sub-command naming. We have at least loadbalancer vs. load-balancer as well. Adding aliases would allow changing the naming while keeping commands backwards compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubernetes nodegroup showto display node-group details in tables. This also adds Nodes table and Anti-affinity field to human output.kubernetes showoutput.(EXPERIMENTAL)notices from kubernetes commands.