feat(server): take stopped/started state into account in completions#332
Merged
feat(server): take stopped/started state into account in completions#332
Conversation
villevsv-upcloud
approved these changes
Sep 20, 2024
Contributor
villevsv-upcloud
left a comment
villevsv-upcloud
left a comment
There was a problem hiding this comment.
Looks good to me! A short changelog entry would be useful.
I'll create a separate PR to accommodate the unrelated linter issues, so this branch can be rebased after that been merged to main.
kangasta
force-pushed
the
feat/server-completion-state
branch
from
00e7888 to
4c858f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could add some more to avoid various other completions for servers let's say in
maintenancestate, but this covers the most common cases for now.