fix: use account currency when formatting credits#666
Merged
kangasta merged 8 commits intoUpCloudLtd:mainfrom Jan 14, 2026
Merged
fix: use account currency when formatting credits#666kangasta merged 8 commits intoUpCloudLtd:mainfrom
kangasta merged 8 commits intoUpCloudLtd:mainfrom
Conversation
kangasta
approved these changes
Jan 14, 2026
Member
kangasta
left a comment
kangasta
left a comment
There was a problem hiding this comment.
Thank you for the (updated) PR! I added small fix to GetAccountDetails call, otherwise looks good to me!
kangasta
changed the title
Contributor
Author
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and sorry for the delay!! I updated the implementation to fetch currency via GetAccountDetails and adjusted the tests to mock that call and update the expected output. All tests pass locally now.