Conversation
davidhammaker
requested review from
cyeanna,
ehsmallmountain,
jayabrown,
mjpatter88 and
ndirig
ndirig
left a comment
ndirig
left a comment
There was a problem hiding this comment.
Just a few minor requests. This looks great otherwise!
|
|
||
| <div class="row justify-content-between align-items-center"> | ||
| <div class="start-image-box order-1 col-12 col-md-5 text-center"> | ||
| <img src="{{ "/assets/images/articles/resource_the-five-disfunctions.jpeg" | |
There was a problem hiding this comment.
The image width should be the same as the article body text.
From design:
vs:
There was a problem hiding this comment.
I now realize these comments are under the wrong image, in the wrong file (this adjustment will need to be in _layouts/article.html, line 17).
This change would affect all other articles, so hopefully this is an easy fix across the board!
| @@ -0,0 +1,200 @@ | |||
| --- | |||
| author: | |||
| duration: 4 Min Read | |||
| a Team: A Leadership Fable"> | ||
| </div> | ||
| <div class="content-box order-2 col-12 col-md-7 resource-detail"> | ||
| <p class="resource-topic">Team DNA and Community</p> |
There was a problem hiding this comment.
This should use overline font styling.
vs
There was a problem hiding this comment.
Same comments apply to other resources
| </p> | ||
|
|
||
| <div class="row justify-content-between align-items-center"> | ||
| <div class="start-image-box order-1 col-12 col-md-5 text-center"> |
There was a problem hiding this comment.
The padding between the photo and the text could be a bit more.
From design:
vs:
I've added the author, updated the font, and fixed the padding! I didn't touch the article layout yet -- I figure that might be part of a different PR that more comprehensively covers style fixes across the site. Let me know if this is good to go! |
2 participants
This PR adds the "Resource Recommendations" article, plus a few very minor tweaks to two of the other articles.