Use datatable column descriptions from server-side #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpstreamData
force-pushed
the
dt_columns_from_server
branch
3 times, most recently
from
df82c96 to
896b6b6
Compare
tsagadar
requested changes
Dec 1, 2024
Collaborator
tsagadar
left a comment
tsagadar
left a comment
There was a problem hiding this comment.
Great to have this functionality unified in all screens. It comes with an additional request to show the UI (vs. embedding a column config already during template generation) but this should not really matter.
UpstreamData
force-pushed
the
dt_columns_from_server
branch
from
896b6b6 to
600920f
Compare
tsagadar
approved these changes
Dec 3, 2024
b-rowan
force-pushed
the
dt_columns_from_server
branch
from
600920f to
7acae19
Compare
Simplify and prettify the column handling slightly.
b-rowan
force-pushed
the
dt_columns_from_server
branch
from
7acae19 to
29350a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of the server-side column handling introduced in #170, handling for the devices page is now slightly cleaner, and handling has been introduced for the remaining pages.