Feat: Postgresql ssl self signed cert support #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Completes: #271 |
b-rowan
requested changes
Mar 17, 2025
Member
b-rowan
left a comment
b-rowan
left a comment
There was a problem hiding this comment.
Couple small changes and comments, seems good overall.
Collaborator
|
Please squash “fixup” commits appropriately and force push, thanks. |
fhuebner
force-pushed
the
postgresql-ssl-self-signed-cert-support
branch
from
3c8f6f5 to
3583739
Compare
b-rowan
approved these changes
Mar 18, 2025
Member
b-rowan
left a comment
b-rowan
left a comment
There was a problem hiding this comment.
Looks good. If you could squash all commits into a single commit (something like feature: Add support for ssl in Postgres connection) so I can merge, as I can't squash and rebase because of the repo settings.
fhuebner
force-pushed
the
postgresql-ssl-self-signed-cert-support
branch
from
3583739 to
48db9ea
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds support to connect to PostgreSQL database servers that have a self signed ca certificate and require SSL mode.