Fixing getting started issues #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easybe
reviewed
Apr 2, 2025
b-rowan
reviewed
Apr 2, 2025
Member
b-rowan
left a comment
b-rowan
left a comment
There was a problem hiding this comment.
Looks good I think, but not sure I like using id as a variable name since it is a built-in, maybe device_id is better?
Migrating from hawkBit it is likely to have tenant default in use. So this change makes it less painful to migrate while existing installations can overwrite the setting to the previous value "ddi".
Running `poetry run pre-commit run --all-files` resulted in the following error: urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate Not loosing much if html|md|yml|yaml are no longer formatted. Maybe someone finds a fix / better solution for this.
tsagadar
force-pushed
the
mm/base-functionality-fixes
branch
from
8b1e2b9 to
34ce050
Compare
The id can be any string with max length of 255 characters. So calling it uuid is just confusing.
swupdate does not only support SemVer. So the version handling logic should be wrapped in our own implementation so that the swupdate behavior can be replicated.
This allows for a simple setup where one has only one type of hardware.
tsagadar
force-pushed
the
mm/base-functionality-fixes
branch
from
34ce050 to
dc33284
Compare
b-rowan
approved these changes
Apr 2, 2025
This was referenced Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commits address the issues raised in #279 / #280.
Create a draft pull request to get quick initial feedback on the implementation. Also will have to do manual testing, current changes are only validated by the unit tests.
Note: it contains a breaking change moving from
ddito thedefaulttenant endpoint. In existing installations this can be reverted by setting the config.