Login screen improvements #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses warning in Chrome browser that login inputs should have autocomplete attribute to aid password managers. https://www.chromium.org/developers/design-documents/create-amazing-password-forms/
b-rowan
previously approved these changes
Apr 21, 2025
Member
b-rowan
left a comment
b-rowan
left a comment
There was a problem hiding this comment.
LGTM. Only possible comment is maybe we want to use server-side validation from bootstrap directly on the form rather than appending a new element.
https://getbootstrap.com/docs/5.3/forms/validation/#server-side
tsagadar
force-pushed
the
mm/fixes-for-login-screen
branch
from
f832479 to
83f93bb
Compare
b-rowan
approved these changes
Apr 21, 2025
Collaborator
Author
With my last force push the screen just shows the server error details without knowing which input is invalid. So a form-wide alert seems preferable IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display error for invalid login. Also add hints for password managers (caused warning in Chrome console).