-
Notifications
You must be signed in to change notification settings - Fork 18
test(e2e): improve e2e tests and reuse util functions and add additional test for device with invalid token #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@easybe this PR is about adding additional test for rejecting devices with invalid token, meanwhile I updated the network configuration so it should rebase smoothy with |
|
I also updated the |
|
Once this is merged I want to review dependency updates then release v0.3.0, as I think we have had a large enough body of changes so far. LMK thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is rebased and the networks are removed this should be good to go.
…nal test for device with invalid token
f646ad7 to
34e1fb1
Compare
|
Just rebased this one. I also think latest changes are mature for |
Nice. Networks are still here, can you remove them then I will approve. |
networks should be there, but they are not hardcoded to specific subnets anymore. |
Can't you use hostnames without networks? I think the tests were passing fine on master with them removed entirely... |
you are correct, sorry I wasn't aware of that. Now they are removed. |
No description provided.