Skip to content

Conversation

@jkuri
Copy link
Collaborator

@jkuri jkuri commented Aug 13, 2025

No description provided.

@jkuri jkuri requested review from b-rowan and easybe August 13, 2025 07:14
@jkuri jkuri self-assigned this Aug 13, 2025
@easybe
Copy link
Collaborator

easybe commented Aug 13, 2025

The Docker Compose network part has already been addressed by @b-rowan: ad3ead9

I don't see why one would need a custom network.

@jkuri
Copy link
Collaborator Author

jkuri commented Aug 13, 2025

@easybe this PR is about adding additional test for rejecting devices with invalid token, meanwhile I updated the network configuration so it should rebase smoothy with plugins branch.

@jkuri
Copy link
Collaborator Author

jkuri commented Aug 13, 2025

I also updated the swupdate image and switched to alpine:3.22 instead of ubuntu:noble and reduced image size from 199MB to 86MB. That should improve the performance of running e2e tests a bit, I think.

@b-rowan
Copy link
Member

b-rowan commented Aug 13, 2025

Once this is merged I want to review dependency updates then release v0.3.0, as I think we have had a large enough body of changes so far. LMK thoughts.

Copy link
Member

@b-rowan b-rowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is rebased and the networks are removed this should be good to go.

@jkuri jkuri force-pushed the e2e-additional-tests branch from f646ad7 to 34e1fb1 Compare August 13, 2025 16:01
@jkuri
Copy link
Collaborator Author

jkuri commented Aug 13, 2025

Just rebased this one. I also think latest changes are mature for v0.3.0

@jkuri jkuri requested a review from b-rowan August 13, 2025 16:03
@b-rowan
Copy link
Member

b-rowan commented Aug 13, 2025

Just rebased this one. I also think latest changes are mature for v0.3.0

Nice.

Networks are still here, can you remove them then I will approve.

@jkuri
Copy link
Collaborator Author

jkuri commented Aug 13, 2025

Just rebased this one. I also think latest changes are mature for v0.3.0

Nice.

Networks are still here, can you remove them then I will approve.

networks should be there, but they are not hardcoded to specific subnets anymore.

@b-rowan
Copy link
Member

b-rowan commented Aug 13, 2025

networks should be there, but they are not hardcoded to specific subnets anymore.

Can't you use hostnames without networks? I think the tests were passing fine on master with them removed entirely...

@jkuri
Copy link
Collaborator Author

jkuri commented Aug 13, 2025

networks should be there, but they are not hardcoded to specific subnets anymore.

Can't you use hostnames without networks? I think the tests were passing fine on master with them removed entirely...

you are correct, sorry I wasn't aware of that. Now they are removed.

@b-rowan b-rowan merged commit 9a375e1 into UpstreamDataInc:master Aug 13, 2025
6 checks passed
@jkuri jkuri deleted the e2e-additional-tests branch August 13, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants