fix(s3): fallback as default in case S3 service is not exposed externally #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-rowan
approved these changes
Aug 18, 2025
Member
b-rowan
left a comment
b-rowan
left a comment
There was a problem hiding this comment.
Seems fine, we may want to look into something like this to get rid of the run_in_executor call though: https://pypi.org/project/aioboto3/
Collaborator
Author
|
Okay, I’ll check into that in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we deployed goosebit with minio in kubernetes cluster and encountered this issue that file on S3 can be uploaded but not downloadable via web UI, neither devices could download it, because we don't have minio exposed externally.
This PR fixes that, all files handled by external S3 service are fallbacking to streaming by default and goosebit handles that properly now.