Reverts back recent changes to the onAfterAction handler. #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@barbatus you are the iron:route boss :) |
Urigo
added a commit
that referenced
this pull request
Apr 23, 2015
Reverts back recent changes to the onAfterAction handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having tested my app, I decided that recent changes to the onAfterAction are too complex.
I propose to revert it back with once change: check it's been compiled only once. It's what regular Angular needs. Anything else is up to a developer. For example, one could create a separate Angular module with onAfterAction (or whatever) and write there any route changes handling (as I did).