Remove Blaze view handler on $scope destroy. #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@barbatus you are the Blaze boss :) |
Contributor
Author
|
@Urigo I think it's pretty clear here. Template is created and rendered dynamically in this directive so we need to remove Blaze reference to it at some point (e.g. when new page is opened) otherwise it will dangle. $destroy is standard Angular event emitted when scope destroyed. |
Owner
|
oh for some reason I so it the other way around. |
Urigo
added a commit
that referenced
this pull request
May 2, 2015
Remove Blaze view handler on $scope destroy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.