Skip to content

Conversation

@sohankshirsagar
Copy link
Contributor

No description provided.

@sohankshirsagar sohankshirsagar merged commit 70e6fe5 into main Jan 8, 2026
5 checks passed
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 9 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="drift/instrumentation/psycopg2/instrumentation.py">

<violation number="1" location="drift/instrumentation/psycopg2/instrumentation.py:222">
P1: InstrumentedConnection.cursor() unconditionally supplies cursor_factory based only on the cursor() argument, which can override a cursor_factory set on connect() and change cursor behavior (e.g., RealDictCursor no longer default). Preserve the connect()-time cursor_factory when cursor() is called without one (e.g., store it on the wrapper and use it as the base_factory).</violation>

<violation number="2" location="drift/instrumentation/psycopg2/instrumentation.py:613">
P2: In REPLAY executemany(), normalize params_list to a list before hashing/matching mocks to keep parity with RECORD mode and avoid iterator/serialization issues.</violation>

<violation number="3" location="drift/instrumentation/psycopg2/instrumentation.py:840">
P2: deserialize_db_value() is applied to all mocked row values and will coerce any ISO-looking string into a datetime (including date-only strings), potentially changing types for text columns. Consider narrowing parsing (e.g., require a time component like 'T' / ':'), or use column type info (type_code) to only deserialize known datetime/timestamp columns.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@jy-tan jy-tan deleted the sohan/e2e-tests-passing branch January 8, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants