Skip to content

Conversation

@sohankshirsagar
Copy link
Contributor

No description provided.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 4 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/e2e.yml">

<violation number="1" location=".github/workflows/e2e.yml:52">
P2: `test -f dist/*.whl` doesn't work correctly with glob patterns. If multiple `.whl` files exist, this fails with a 'binary operator expected' error. If no files match, bash passes the literal string `dist/*.whl` to test. Use `ls dist/*.whl` instead which properly handles globs.</violation>

<violation number="2" location=".github/workflows/e2e.yml:60">
P2: The version extraction lacks error handling. If the GitHub API call fails or returns an error response, VERSION will be empty and the workflow continues with an empty `TUSK_CLI_VERSION`. Consider adding validation that VERSION is not empty before proceeding.</violation>
</file>

<file name="drift/core/drift_sdk.py">

<violation number="1" location="drift/core/drift_sdk.py:119">
P2: Consider using `TUSK_ENV` instead of `ENV` to maintain consistency with other SDK environment variables (e.g., `TUSK_API_KEY`, `TUSK_DRIFT_MODE`, `TUSK_SAMPLING_RATE`). Using a generic `ENV` variable could cause unexpected behavior if users have it set for unrelated purposes.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@sohankshirsagar sohankshirsagar merged commit 8d55f35 into main Jan 9, 2026
13 checks passed
@sohankshirsagar sohankshirsagar deleted the sohan/run-e2e-in-ci branch January 9, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants