Skip to content

Conversation

@sohankshirsagar
Copy link
Contributor

@sohankshirsagar sohankshirsagar commented Jan 14, 2026

  • use published schemas
  • update node sdk to use latest schemas

Will include kinde instrumentation in another PR


Note

Enables CLI-initiated time travel and improves SDK-CLI comms reliability.

  • Add background reader thread in ProtobufCommunicator to process CLI-initiated messages (handles SET_TIME_TRAVEL) and route responses via pre-registered Events to avoid races
  • Implement _handle_set_time_travel_sync and _send_message_sync; guard socket sends with a shared lock; enhance cleanup to stop thread and unblock waiters
  • Async/sync response waiting: _wait_for_response(_async) and pre-registration before send; fall back to direct socket reads when no background reader
  • Extend ConnectRequest to include runtime and re-export Runtime; import/export SetTimeTravelRequest/Response
  • Requests instrumentation: set is_pre_app_start based on sdk.app_ready in REPLAY path
  • Bump dependency tusk-drift-schemas to >=0.1.24; CI/build workflow unchanged functionally

Written by Cursor Bugbot for commit 4a6c066. This will update automatically on new commits. Configure here.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 9 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="pyproject.toml">

<violation number="1" location="pyproject.toml:30">
P1: Do not depend on a developer-local file path for `tusk-drift-schemas`; publishing/installing the SDK elsewhere will fail because the path is not accessible. Restore a published version spec instead.</violation>
</file>

<file name="drift/core/communication/communicator.py">

<violation number="1" location="drift/core/communication/communicator.py:835">
P1: Background reader enters busy loop when connection closes. When `_recv_exact` returns `None` (indicating a closed connection), the code executes `continue` which causes a tight infinite loop at 100% CPU. The loop should `break` instead to properly terminate when the connection is closed.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/ci.yml">

<violation number="1">
P2: CI now installs uv with `version: "latest"`, which removes the explicit pin and makes builds non‑deterministic. Pin the uv binary to a known version (e.g., 0.9.24) so CI doesn’t break when a new uv release introduces breaking changes.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/ci.yml">

<violation number="1" location=".github/workflows/ci.yml:31">
P2: `grep` exits non‑zero when no match is found, so this debug step will fail the whole CI job whenever "asgiref" is not present in `uv.lock`. Guard the command so missing matches don’t break linting.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@sohankshirsagar sohankshirsagar merged commit 1f9b6c6 into main Jan 15, 2026
17 checks passed
@sohankshirsagar sohankshirsagar deleted the sohan/kinde-auth branch January 15, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants