test: enforce strict replay sandboxing in e2e fixtures#79
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
There was a problem hiding this comment.
1 issue found across 40 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="drift/instrumentation/grpc/e2e-tests/src/greeter_pb2_grpc.py">
<violation number="1" location="drift/instrumentation/grpc/e2e-tests/src/greeter_pb2_grpc.py:8">
P2: This raises the generated gRPC minimum version to 1.78.0, but the fixture requirements still allow grpcio 1.60+. Align dependency constraints (or regenerate with the intended toolchain) to avoid import-time RuntimeError on environments that resolve <1.78.0.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
3 issues found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/e2e.yml">
<violation number="1" location=".github/workflows/e2e.yml:131">
P2: This artifact upload points into `.tusk`, but `upload-artifact@v4` ignores hidden directories by default, so these replay logs will be silently skipped unless you opt in to hidden files.</violation>
<violation number="2" location=".github/workflows/e2e.yml:232">
P2: This upload has the same hidden-directory problem: `.tusk/logs/*` is excluded by `upload-artifact@v4` unless `include-hidden-files` is enabled.</violation>
<violation number="3" location=".github/workflows/e2e.yml:326">
P2: This upload step will also skip the replay logs, because `.tusk` is hidden and `upload-artifact@v4` does not include hidden files by default.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/e2e.yml">
<violation number="1" location=".github/workflows/e2e.yml:17">
P2: The workflow is pinned to a temporary feature branch (`socket-location`) for the CLI under test, which makes CI results unstable and can break all e2e jobs if that branch changes or is removed.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.


Summary
Enable strict replay sandboxing across the Python e2e and stack-test fixtures so local/CI replay runs exercise the sandboxed path instead of silently falling back. This also updates sandbox-sensitive HTTP fixtures to install SOCKS support, since strict replay routes outbound HTTP through a SOCKS proxy.
Changes
replay.sandbox.mode: strictin all checked-in e2e and stack-test.tusk/config.yamlfixturesappservice in the testdocker-compose.ymlfiles:cap_add: [SYS_ADMIN]security_opt: [seccomp=unconfined, apparmor=unconfined]bubblewrapandsocatin the sharedpython-e2e-baseimage used by the test containershttpxandfastapie2e test requirements to usehttpx[socks]and document why that extra is needed under strict replay sandboxingNotes
httpx-based fixtures needed SOCKS support because replay now intercepts outbound HTTP through a SOCKS proxy