Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous unification PR put bwrap into its own pgrp via
Setpgid: trueto support pgrp-broadcast on the 2nd Ctrl-C. This stole the controlling terminal's foreground from sandboxed TUIs (e.g. OpenCode, Claude Code), causing them to receive SIGTTIN and stop on startup.psshowedSTAT=T/TlandTPGID != PGIDfor the sandboxed subtree.Drop
Setpgidon bwrap and the now-unusedPgrpBroadcast/killProcessGroupmachinery. SIGKILL on the 2nd signal plusbwrap --die-with-parentis sufficient to tear down the subtree.ppoll+eventfd shutdown, SIGHUP handling, drain timeout, and the unifiedSignalForwarderare all retained.Changes
internal/sandbox/runtime_exec_argv_linux.go: dropSetpgid: trueon bwrap; replacekillProcessGroup(...)withProcess.Signal(SIGTERM)in the supervisor-died-first branch; update doc comment.internal/sandbox/sigproxy.go: removePgrpBroadcastfield andkillProcessGrouphelper (no production callers).internal/sandbox/sigproxy_test.go: dropSetpgidfrom test child and the deleted-helper test.cmd/fence/main.go: clean up stale comment onstartCommandWithSignalProxy.