Ignore /mnt prefix when scanning for multicall binaries on wsl2#96
Closed
dwt wants to merge 2 commits intoUse-Tusk:mainfrom
Closed
Ignore /mnt prefix when scanning for multicall binaries on wsl2#96dwt wants to merge 2 commits intoUse-Tusk:mainfrom
dwt wants to merge 2 commits intoUse-Tusk:mainfrom
Conversation
This is is problematic because /mnt is the wsl2 bridge into the windows file system, which is shared via the 9p protocol. This is really slow and can take multiple minutes for the thousands of windows binaries that are potentially found there. Even though it would be correct to search for multicall binaries there, it is prohibitively expensive. So we don't for now.
Collaborator
Author
|
Not quite sure this is the correct way to do it - feedback appreciated as always. Since my dev box is a Mac, I'm not sure yet how to reliably test on linux locally. Thus the code is a bit speculative. Ah well. Better try than not try. |
This was referenced Apr 1, 2026
Collaborator
Author
|
closing for now in favor of #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #95
This is is problematic because /mnt is the wsl2 bridge into the windows file system, which is shared via the 9p protocol.
This is really slow and can take multiple minutes for the thousands of windows binaries that are potentially found there.
Even though it would be correct to search for multicall binaries there, it is prohibitively expensive. So we don't for now.