ci(verification): fix actionlint SC2086 in lean-build zero-sorry audit#193
Merged
Conversation
The audit step assembled a file list into a string variable and then passed it unquoted to grep, relying on word-splitting. shellcheck/SC2086 flagged the unquoted expansion (real footgun if any filename ever contained whitespace), and actionlint failed on every push as a result. Switch to `find -print0 | xargs -0 grep -nwH "sorry"` — same future-proof glob over all LeanSpike modules minus Spec.lean, but NUL-delimited so the audit is correct under any filename. Verified locally: - actionlint clean on the workflow file - positive case: zero-sorry repo state → audit exits 1 (passes) - negative case: synthetic sorry in non-Spec module → audit exits 0 (fails)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
✅ Post-merge smoke passedMerged: Steps
CI on the merge commit ( Log: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
actionlintCI check that has been failing since PR #164 merged.The zero-sorry audit step in
.github/workflows/lean-build.ymlassembled a list of.leanfiles into a string variable and then passed it unquoted togrep, relying on shell word-splitting:shellcheck/SC2086 flags this — a real footgun if any future filename contains whitespace. actionlint propagated that as a job failure on every push touching the workflow.
Switched to the NUL-delimited pipeline:
Same future-proof glob over all LeanSpike modules except
Spec.lean, but correct under any filename.Test plan
actionlint .github/workflows/lean-build.ymlexits clean locallysorryinjected into a non-Spec module → audit exits 0 with file:line:match printed (audit fails as intended)actionlintCI check passes on this PRWorkflow trigger paths include
.github/workflows/lean-build.ymlitself, so thelean-buildjob will also re-run on this PR.