Skip to content

Fix generation of ORDER clause based on callback. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ADmad merged 4 commits into from
Apr 21, 2020
Merged

Fix generation of ORDER clause based on callback. #4

ADmad merged 4 commits into from
Apr 21, 2020

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Apr 21, 2020

No description provided.

@ADmad ADmad linked an issue Apr 21, 2020 that may be closed by this pull request
Callback seems to be ignored in some cases #3
Closed
@ADmad
Copy link
Member Author

ADmad commented Apr 21, 2020

@eaxexe Please try out this patch and confirm it fixes the issue.

@ADmad ADmad force-pushed the issue-3 branch 2 times, most recently from ab3952b to ea3ecaf Compare April 21, 2020 14:21
@ADmad ADmad closed this Apr 21, 2020
@ADmad ADmad reopened this Apr 21, 2020
@ADmad ADmad closed this Apr 21, 2020
@ADmad ADmad reopened this Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #4 into master will increase coverage by 4.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master        #4      +/-   ##
=============================================
+ Coverage     95.45%   100.00%   +4.54%     
  Complexity       11        11              
=============================================
  Files             1         1              
  Lines            22        21       -1     
=============================================
  Hits             21        21              
+ Misses            1         0       -1
Impacted Files Coverage Δ Complexity Δ
src/Model/Behavior/OrderlyBehavior.php 100.00% <100.00%> (+4.54%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969c459...f07af9a. Read the comment docs.

@ADmad ADmad merged commit b27f120 into master Apr 21, 2020
@ADmad ADmad deleted the issue-3 branch April 21, 2020 17:39
@OtterlyOlive
Copy link

OtterlyOlive commented Apr 23, 2020 •
edited
Loading

@eaxexe Please try out this patch and confirm it fixes the issue.

@ADmad Works beautifully, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Callback seems to be ignored in some cases

3 participants

@ADmad @OtterlyOlive