Skip to content

Possible to configure table name#13

Closed
LubosRemplik wants to merge 2 commits intoUseMuffin:masterfrom
LubosRemplik:table-config
Closed

Possible to configure table name#13
LubosRemplik wants to merge 2 commits intoUseMuffin:masterfrom
LubosRemplik:table-config

Conversation

@LubosRemplik
Copy link
Copy Markdown
Contributor

Closes #10

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2018

Codecov Report

Merging #13 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
+ Coverage     67.88%   68.18%   +0.29%     
  Complexity       36       36              
============================================
  Files             6        6              
  Lines           109      110       +1     
============================================
+ Hits             74       75       +1     
  Misses           35       35
Impacted Files Coverage Δ Complexity Δ
src/Model/Table/TokensTable.php 88.57% <100%> (+0.33%) 9 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacc1be...d0412bf. Read the comment docs.

@LubosRemplik
Copy link
Copy Markdown
Contributor Author

I have updated readme with latest changes (how to configure the plugin)

@LubosRemplik
Copy link
Copy Markdown
Contributor Author

I can see we've both updated readme, ignore my second commit then

@ADmad
Copy link
Copy Markdown
Member

ADmad commented Feb 1, 2018

You'll need to rebase your branch on top of upstream master and resolve the conflict so that your PR can be merged. :)

@LubosRemplik LubosRemplik deleted the table-config branch February 1, 2018 19:44
@LubosRemplik
Copy link
Copy Markdown
Contributor Author

Sorry deleted branch by mistake, this is closed and another pull request #14 is opened without readme changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants