Desktop updater: keep checking after a declined update, surface errors, fix install-on-quit leak#1305
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 9f93d69 | Commit Preview URL Branch Preview URL |
Jul 04 2026, 05:40 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 9f93d69 | Jul 04 2026, 05:41 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
22ac04e to
4121d9a
Compare
b33281c to
15b1749
Compare
This was referenced Jul 4, 2026
Merged
4121d9a to
12e7d75
Compare
15b1749 to
11c801d
Compare
11c801d to
9f93d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes five updater state-machine issues:
autoInstallOnAppQuit=falseafter reset data and retry.quitAndInstallstops the supervised monitor before restart.Re-prompt policy
Unit coverage
autoInstallOnAppQuiton reset and retry.Verification
bun run --cwd apps/desktop test -- src/main/updater-state.test.tsbun run typecheckbun run lintbun run format:checkBehavioral updater verification is deferred. These flows need real GitHub releases; this PR does not launch the Electron app on the host.
Stack