fix(plugin-mcp): import Effect-native SDK symbols from /core in the core build#1310
Merged
RhysSullivan merged 1 commit intoJul 4, 2026
Conversation
Collaborator
|
thanks, will also get some better CI in place for these + actually useful docs separating 'executor the platform' from 'executor the product' so it'll be a lot easier to use these sdks without bringing along a bunch of other stuff like toolkits and policies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@executor-js/plugin-mcp's./coreentry is unusable. Importing from it throwsat module load:
This reproduces in the published
1.5.28and2.0.0artifacts. To use/coretoday I had to patch the installed package;
this PR removes the need for that.
Root cause
Two mcp plugin source files import Effect-native-only symbols from the bare root
"@executor-js/sdk"instead of"@executor-js/sdk/core":packages/plugins/mcp/src/sdk/plugin.ts(tool,definePlugin,ToolResult,ToolName, ...)packages/plugins/mcp/src/sdk/invoke.ts(ElicitationId,FormElicitation,UrlElicitation)tsuppreserves import specifiers verbatim (no build-time rewrite to/core), so thebare root import survives into
dist/core.js, where it resolves to the promise facadethat lacks those exports. That is why the fix is a source change, not a bundler config
change.
Fix
Import the Effect-native symbols from
@executor-js/sdk/corein those two sourcefiles. This matches the existing convention: sibling dual-surface plugins
(
onepassword,google,microsoft,openapi) already importdefinePlugin,tool,ToolResult, and related Effect-native symbols from@executor-js/sdk/corein source.
Verification
/corechunk now imports thesymbols from
@executor-js/sdk/core, and that no emitted JS inpackages/plugins/mcp/dist/*.jsstill imports the bare@executor-js/sdkroot.typecheckandlintpass for the change.Before (emitted
/coreartifact):After:
Scope
Confirmed unique to
plugin-mcp. Most sibling dual-surface plugins already usethe correct
@executor-js/sdk/coresource imports, so no broader change isneeded.