Fix cross-session resume lease cleanup deleting the owner entry#1314
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 94e12c9 | Jul 04 2026, 08:22 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 94e12c9 | Commit Preview URL Branch Preview URL |
Jul 04 2026, 08:21 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cross-session resume still failed in production after #1312. Root cause: when the resume arrives on a session that does not own the execution, the local engine miss triggers the resume lifecycle's settle hook, and
releasePendingApprovalLeasetreated "no local lease" as permission to delete the owner-directory entry. Session B deleted session A's entry, then the directory fallback read null and returnedexecution_not_found.Found via a new worker-level e2e that runs the real worker with real Durable Objects and two real MCP sessions (pause on A, resume on B). Red before the fix with exactly the production symptom; green after.
Fix
releasePendingApprovalLeaseno longer deletes the directory entry when there is no local lease; deletion happens only when the owning session releases its lease.console.errorevents (mcp_execution_owner_directory_error,mcp_model_resume_forward_error) and span annotations, so this class of silent degradation is diagnosable in production telemetry.Tests
typecheck 42/42, lint clean, hosts/mcp 64, hosts/cloudflare 29, new e2e green.