Per-service picker fan-out UI#1315
Open
RhysSullivan wants to merge 8 commits into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | a83a2fb | Commit Preview URL Branch Preview URL |
Jul 04 2026, 09:28 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | a83a2fb | Jul 04 2026, 09:29 AM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
ms-per-service
branch
from
046ff96 to
d53c213
Compare
When presets are checked and custom scopes entered in the same submit, the workloads already fan out through addWorkloads, so the legacy addGraph call now carries only the custom scopes. Empty presetIds with custom scopes no longer falls back to the default workload selection.
The Photos flow now initializes the fan-out picker with both Photos products checked, so there is no single-integration name/namespace form. Assert the checked presets, the scope count, and the preset-identity settings copy instead.
Result panel containers, per-preset result rows (with a data-state of added/skipped/failed), per-row retry buttons, submit buttons, and preset checkboxes get data-testid attributes so e2e scenarios can bind to structure instead of copy.
Cover the Google product and Microsoft workload pickers end to end: check several presets, submit, and assert each fans out to its own integration with added/skipped result rows, a per-service detail page, and separate list entries. The add paths fetch real provider specs (Google Discovery, msgraph-metadata), so these run against the live specs rather than an emulator. Also stub the Google per-service OAuth scenario as a documented skip: the preset add path hardcodes Discovery and OAuth endpoints to real Google with no emulator override, so it cannot drive an auto-approving consent flow yet.
RhysSullivan
force-pushed
the
picker-fanout-ui
branch
from
9fc44d4 to
a82634c
Compare
This was referenced Jul 4, 2026
On selfhost every scenario shares the bootstrap admin, so integrations added by the fan-out specs stay in the sidebar under their workload names. Page-wide getByText lookups for names like Outlook Mail then match both the sidebar link and the picker row and trip Playwright's strict mode. Scope those lookups to the main landmark in the provider plugins spec and the two fan-out specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1309. The Google and Microsoft add flows keep the bulk-select picker but now create one integration per selected service via addServices/addWorkloads, with an in-modal result panel (added / already exists / failed with per-service retry). Custom Discovery URLs and custom Graph scopes keep their existing paths; a mixed Microsoft submit no longer folds the selected presets into the custom bundle. Adds stable data-testids for the e2e suite.
Independently reviewed (ship-with-nits; both nits fixed: mixed-flow double-add, google-photos e2e spec updated for the multi-select flow).
Stack