Allow Experiment Safety Review feature to be enabled for STFC without dependency on Scheduler feature flag #1799
SourangshuSTFC
started this conversation in
General
Replies: 1 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Problem statement: Currently, to visit Experiments page to view experiments or initiate Experiment Safety Review, the Scheduler feature flag needs to be checked under Features section, or neds to be preset via config. This dependency is not currently required for STFC as STFC will continue to use the existing Scheduler, according to latest discussion. Hence, the dependency on this check can be disabled now.
Related STFC User story (proposed):
Decouple SRA initiation from the Scheduling feature flag
As a developer,
I want SRA initiation for Xpress Technique Proposals to be controlled by the new ERA system configuration rather than the existing Scheduling feature flag,
so that Sample Risk Assessments can be started without requiring Scheduling to be enabled for the proposal flow.
Actions/Technical details:
In apps/frontend/src/components/menu/MenuItems.tsx, menu items or buttons linking to pages /Experiments and /ExperimentTime are blocked if isSchedulerEnabled value returns false, and this check depends on Scheduling features enabled. This needs a workaround for STFC users e.g. Sample Safety team / User Officer / Instrument Scientist to perform Experiment safety review
A change is needed in STFC config to enable Experiment Safety Review feature to be enabled:-
In apps/backend/src/config/stfc/configureSTFCEnvironment.ts the enableDefaultStfcFeatures method needs to set FeatureId.EXPERIMENT_SAFETY_REVIEW via db.setFeatures() method.
All reactions