fix: sample with new arch enable#201
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important Review skippedToo many files! This PR contains 151 files, which is 1 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (80)
📒 Files selected for processing (151)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoEnable new React Native architecture and modernize sample app
WalkthroughsDescription• Enable new React Native architecture (TurboModules + Fabric) in sample app • Modernize AppDelegate with ReactNativeDelegate and factory pattern • Remove legacy sample and example folder references from scripts • Update dependencies and React Native version to 0.81.4 • Add Podfile helper to fix ReactCodegen third-party component sources Diagramflowchart LR
A["Legacy AppDelegate<br/>RCTRootView pattern"] -->|"Refactor to new arch"| B["ReactNativeDelegate<br/>RCTReactNativeFactory"]
C["RCT_NEW_ARCH_ENABLED<br/>false"] -->|"Enable"| D["RCT_NEW_ARCH_ENABLED<br/>true"]
E["Legacy sample/example<br/>folder references"] -->|"Remove"| F["Single sample folder<br/>in scripts"]
G["React Native 0.79.6"] -->|"Upgrade"| H["React Native 0.81.4"]
B --> I["Fabric + TurboModules<br/>enabled"]
D --> I
File Changes1. sample/ios/sample/AppDelegate.swift
|
Code Review by Qodo
|
|
Auto review disabled due to large PR. If you still want me to review this PR? Please comment |
|
CodeAnt AI finished reviewing your PR. |
9569a6b to
571910b
Compare
CodeAnt-AI Description
Enable the sample app on the new React Native architecture and remove old sample references
What Changed
sample/app and use the current React Native versionexampleandlegacy-samplereferences were removed from setup scripts, docs, and project pathsImpact
✅ Sample app runs with the new architecture✅ Fewer setup errors from outdated sample paths✅ Clearer setup for local development and CI💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.