Skip to content

Conversation

@AsswinCR
Copy link
Contributor

@AsswinCR AsswinCR commented Oct 4, 2021

Fixes #26

Short description of what this resolves:

issue name :- new lesson: StringBuilder in Java

What Changes proposed in this pull request:

-Added Documentation file for StringBuilder.
-Documentation contains Introduction, Sample Code, Code Explanation, and Code Analysis.

Checklist

  • Added documentation so that the program is self-explanatory and educational.
  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
I have added the Documentation for String Builder, kindly review it and give feedback :).

@AsswinCR
Copy link
Contributor Author

AsswinCR commented Oct 4, 2021

@Utkarsh1504 kindly check the documentation for String Builder ( new lesson: StringBuilder in Java #26) .

section: "Strings In Depth"
description: "learn strings in depth"
---
## Introduction
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Introduction

please remove this line(heading), this will on the website by default

Copy link
Owner

@Utkarsh1504 Utkarsh1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the first heading as it will be by default on the site. :octocat:

@AsswinCR
Copy link
Contributor Author

AsswinCR commented Oct 5, 2021

@Utkarsh1504 I have removed the title as you told me, please verify it. thanks

@Utkarsh1504 Utkarsh1504 added approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request and removed requested-change labels Oct 6, 2021
@Utkarsh1504
Copy link
Owner

Nicely done, Thank you for your contribution! :octocat: 👍🏻

@AsswinCR
Copy link
Contributor Author

AsswinCR commented Oct 6, 2021

Thank you !! @Utkarsh1504 :)

@Utkarsh1504 Utkarsh1504 merged commit ad3c2a9 into Utkarsh1504:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved for approved PRS hacktoberfest-accepted eligible PRs for hactoberfest ✅ Ready for merge approved pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new lesson: StringBuilder in Java

2 participants