Skip to content

Remove implicit object lifetime cast #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BoxyUwU wants to merge 1 commit into
base: new-new-devices
Choose a base branch
from
Open

Remove implicit object lifetime cast #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,39 +791,39 @@ macro_rules! as_dyn_chronology {
///the original `PointerDereferencer`. Unfortunately `T` currently must be `Sized` due to language
///limitations.
impl<T> PointerDereferencer<*mut T> {
as_dyn_updatable!(*mut dyn Updatable<E>);
as_dyn_getter!(*mut dyn Getter<U, E>);
as_dyn_settable!(*mut dyn Settable<U, E>);
as_dyn_time_getter!(*mut dyn TimeGetter<E>);
as_dyn_chronology!(*mut dyn Chronology<U>);
as_dyn_updatable!(*mut (dyn Updatable<E> + '_));
as_dyn_getter!(*mut (dyn Getter<U, E> + '_));
as_dyn_settable!(*mut (dyn Settable<U, E> + '_));
as_dyn_time_getter!(*mut (dyn TimeGetter<E> + '_));
as_dyn_chronology!(*mut (dyn Chronology<U> + '_));
}
///These functions get a `PointerDereferencer<*const RwLock<dyn Trait>>` from a
///`PointerDereferencer<*const RwLock<T>>` where `T: Trait`. Because raw pointers are `Copy`, they
///only require `&self` and do not consume the original `PointerDereferencer`. Unfortunately `T`
///currently must be `Sized` due to language limitations.
#[cfg(feature = "std")]
impl<T> PointerDereferencer<*const RwLock<T>> {
as_dyn_updatable!(*const RwLock<dyn Updatable<E>>);
as_dyn_getter!(*const RwLock<dyn Getter<U, E>>);
as_dyn_settable!(*const RwLock<dyn Settable<U, E>>);
as_dyn_time_getter!(*const RwLock<dyn TimeGetter<E>>);
as_dyn_updatable!(*const RwLock<dyn Updatable<E> + '_>);
as_dyn_getter!(*const RwLock<dyn Getter<U, E> + '_>);
as_dyn_settable!(*const RwLock<dyn Settable<U, E> + '_>);
as_dyn_time_getter!(*const RwLock<dyn TimeGetter<E> + '_>);
}
///These functions get a `PointerDereferencer<*const Mutex<dyn Trait>>` from a
///`PointerDereferencer<*const Mutex<T>>` where `T: Trait`. Because raw pointers are `Copy`, they
///only require `&self` and do not consume the original `PointerDereferencer`. Unfortunately `T`
///currently must be `Sized` due to language limitations.
#[cfg(feature = "std")]
impl<T> PointerDereferencer<*const Mutex<T>> {
as_dyn_updatable!(*const Mutex<dyn Updatable<E>>);
as_dyn_getter!(*const Mutex<dyn Getter<U, E>>);
as_dyn_settable!(*const Mutex<dyn Settable<U, E>>);
as_dyn_time_getter!(*const Mutex<dyn TimeGetter<E>>);
as_dyn_updatable!(*const Mutex<dyn Updatable<E> + '_>);
as_dyn_getter!(*const Mutex<dyn Getter<U, E> + '_>);
as_dyn_settable!(*const Mutex<dyn Settable<U, E> + '_>);
as_dyn_time_getter!(*const Mutex<dyn TimeGetter<E> + '_>);
}
//There are Chronology impls for RwLock<C> and Mutex<C> where C: Chronology. It is necessary to
//implement Updatable etc. for *const RwLock<T> and *const Mutex<T> directly rather than doing it
//more generically like for Chronology because they require mutability.
impl<T> PointerDereferencer<*const T> {
as_dyn_chronology!(*const dyn Chronology<U>);
as_dyn_chronology!(*const (dyn Chronology<U> + '_));
}
//FIXME: Make one of these work if you can, preferably From since it implies Into.
/*impl<P> From<PointerDereferencer<P>> for P {
Expand Down