Conversation
Now it directly saves to the module folder. Still need to figure out how to allow local changes easily. might just do a /v5 developerMode command or similar
[skip-native-auto]
…codex. [skip-native-auto]
…codex. [skip-native-auto]
…codex. [skip-native-auto]
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d85e103e18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| isLoaded = true | ||
| } |
There was a problem hiding this comment.
onInitialize() now only validates the token and marks the loader as loaded, but it no longer executes the downloaded V5 module entrypoint. ModuleManager.setup() (called from CTMixinPlugin.onLoad) only prepares module metadata/jars and does not run entries (entryPass is only called from CTJS.load()), so after a normal game start the V5 scripts never run until the user manually reloads CT.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
| shutDownHard() | ||
| } |
There was a problem hiding this comment.
onMixinPlugin() fetches and validates a JWT before checking isLocalDeveloperModeEnabled(). In local/offline development (or any run without a token), this throws before reaching the developer-mode branch, so the documented local module workflow is blocked even when modules/V5 already exists. The developer-mode bypass should happen before hard-failing on token absence.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
why would you ever develop a macro while offline? hello? darioush propaganda bot.
|
Grrrr. Okay fine, I will allow you to open source it with pathfinder, I'm too tired to argue. Just please spam README or smth with the GPL license repeatedly, so people know that their skidware has to be open too cough hexis cough |
my thinking was that hopefully it would be easier for them to just like vibecode there own modules in v5 rather than skid an entire client. |
2 participants
@codex