changes to make parallel with DID v080 #293
Merged
+39
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
I was trying to think if there is a reason I should leave this as a request rather than just merging it..I can't think of a good reason so I'll just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few changes to keep things parallel with DID v080
In DID v080, I changed the
readjsonfilelocationmethod indid.documentso that it no longer accepts partial paths, likestimulus/stimulus_presentation. So I had to remove a lot of those. I used to use those partial paths, thinking it would help a programmer find the document, but gave it up, and I think having the system search for so many possibilities might make it slower.It also requires an update to
vhlab-toolbox-matlabso thatvlt.file.findfilegroupscan deal with either strings or character arrays. I added an argument block so it is always converted to a char.