Merge small and large clock#363
Conversation
- Introduced ClockMode class with configuration and handling logic. - Updated .env and modules.ts to include new clock mode. - Refactored Deprecated.py to deprecate large and small clock modes. - Added Clock component in the web application with state management. - Updated WebSocket integration for clock mode settings.
|
Thanks for the effort — this is already looking quite clean. 🙌🏻
I haven’t tested the changes functionally yet, but I’m looking forward to seeing only one clock in the list. 👍🏻 |
|
I fixed some clang-tidy findings and updated the documentation. I wasn't happy with duplicating the draw() calls for small and large fonts, so I did some refactoring now. The only variables that are conditional now are the bottom y position (yBot) and the x padding of the digits (xPad lambda function). |
Co-authored-by: Jan-Petter Gundersen <europe.jpg@gmail.com>
Co-authored-by: Jan-Petter Gundersen <europe.jpg@gmail.com>
This reverts commit 8cb071d.
|
I noticed that This is mostly a matter of personal preference, but I’ve typically used the small clock with seconds enabled and the large clock with seconds disabled. Feel free to adjust either setting as you see fit — or leave it unchanged. |
|
Changing the default ticking state wasn't really intentional. Set it to false now. |
|
I noticed there's quite some duplicated code in the deprecation script, so I decided to refactor it. In case you don't like it, we can just revert the last commit. |
JanPetterMG
left a comment
There was a problem hiding this comment.
Thanks for the thorough iteration on this. The changes look solid, CI is green, and everything discussed has been addressed.
Approving and merging. 🚀
Key changes
Impact