Silence Clang-tidy "reinterpret-cast" and "make-member-function-const" warnings#370
Merged
JanPetterMG merged 4 commits intomainfrom Feb 22, 2026
Merged
Conversation
JanPetterMG
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "NOLINT" comments to silence some Clang-tidy warnings on lines that can't be optimized further.
For context: reinterpret-cast can technically be replaced by two static-casts, but that is even worse, and the canonical fix for those findings are to use reinterpret-cast instead.
Key changes
Impact
Reduces the warning count, and avoids false positives. Most of all, it functions as a signal that people shouldn't try to fix the warnings, because someone already tried and met an dead-end in the process.