Skip to content

feat(RichCell): decrease min-height#9283

Merged
EldarMuhamethanov merged 3 commits intomasterfrom
e.muhamethanov/7859/update-min-height-rich-cell
Dec 16, 2025
Merged

feat(RichCell): decrease min-height#9283
EldarMuhamethanov merged 3 commits intomasterfrom
e.muhamethanov/7859/update-min-height-rich-cell

Conversation

@EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Dec 11, 2025


  • e2e-тесты
  • Дизайн-ревью
  • Release notes

Описание

Сделал минимальную высоту RichCell как SimpleCell

Release notes

Исправления

  • RichCell: минимальная высота RichCell уменьшена до 48px - compact и 44px - regular

…-cell

# Conflicts:
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-android-chromium-dark-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-android-chromium-light-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-ios-webkit-dark-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-ios-webkit-light-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-vkcom-chromium-dark-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-vkcom-chromium-light-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-vkcom-firefox-dark-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-vkcom-firefox-light-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-vkcom-webkit-dark-1-snap.png
#	packages/vkui/src/components/FormItem/__image_snapshots__/formitem-vkcom-webkit-light-1-snap.png
#	packages/vkui/src/components/RichCell/RichCell.module.css
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 11, 2025 11:13
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 425.22 KB (0%)
JS (gzip) 128.64 KB (0%)
JS (brotli) 105.22 KB (0%)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 373.14 KB (0%)
CSS (gzip) 46.13 KB (-0.02% 🔽)
CSS (brotli) 36.57 KB (+0.11% 🔺)

@github-actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit 83d3fca

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (a5d9d13) to head (83d3fca).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9283   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         416      416           
  Lines       11199    11199           
  Branches     4212     4212           
=======================================
  Hits        10643    10643           
  Misses        556      556           
Flag Coverage Δ
unittests 95.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9283/83d3fca96c7dd0cc5b769da1458ff693c37e250b/pkg/@vkontakte/vkui/_pkg.tgz

Commit 83d3fca

Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to me

@EldarMuhamethanov EldarMuhamethanov merged commit 253a9fb into master Dec 16, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7859/update-min-height-rich-cell branch December 16, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][RichCell]: Минимальная высота как в Cell

4 participants