Skip to content

fix(Clickable): fix hasActive changing#9663

Merged
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/8783/fix-cell-dragging
Apr 2, 2026
Merged

fix(Clickable): fix hasActive changing#9663
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/8783/fix-cell-dragging

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor


  • Release notes

Описание

Исправлен баг в Cell при draggable: после завершения перетаскивания элемент мог оставаться в визуально активном состоянии.

Проблема воспроизводилась из-за того, что во время drag у кликабельного состояния отключался hasActive, но локальный activated в Clickable мог не сбрасываться в некоторых pointer-сценариях. После завершения drag подсветка снова появлялась

Изменения

  • В Clickable/useState обновлена логика сброса active-состояния в useActive:
    • setActivated(false) теперь вызывается не только при lockState, но и при !hasActive.

Release notes

Исправления

  • Cell: исправлено залипание active-состояния после перетаскивания (draggable)

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner April 2, 2026 11:15
@github-actions github-actions Bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

size-limit report 📦

Path Size
JS 408.99 KB (+0.01% 🔺)
JS (gzip) 125.31 KB (+0.01% 🔺)
JS (brotli) 103.31 KB (+0.06% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 375.11 KB (0%)
CSS (gzip) 46.28 KB (0%)
CSS (brotli) 36.64 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 36c8610

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9663/36c8610382b9398064a66933d1ef59b8bbdb705a/pkg/@vkontakte/vkui/_pkg.tgz

Commit 36c8610

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.35%. Comparing base (5942f61) to head (36c8610).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9663   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         439      439           
  Lines       12052    12052           
  Branches     4374     4374           
=======================================
  Hits        11492    11492           
  Misses        560      560           
Flag Coverage Δ
unittests 95.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov merged commit 427ce16 into master Apr 2, 2026
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8783/fix-cell-dragging branch April 2, 2026 12:09
vkcom-publisher pushed a commit that referenced this pull request Apr 2, 2026
Co-authored-by: e.mukhametkhanov <e.mukhametkhanov@vk.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Cell]: на тач-устройствах при кликабельном draggable залипает состояние активации

2 participants