changed some of the runtime logs to server logs#1285
Merged
Conversation
DrDet
reviewed
Apr 14, 2025
DrDet
reviewed
May 13, 2025
Contributor
There was a problem hiding this comment.
It seems, that we already have the criteria to distinguish critical 'runtime' and 'server' errors from warnigns -- it's uncaught == true
Line 352 in 6c04688
DrDet
requested changes
May 21, 2025
bdd66bd to
c3b2a35
Compare
DrDet
previously approved these changes
Jun 6, 2025
a08db05 to
b82fcbe
Compare
DrDet
previously approved these changes
Jun 6, 2025
8185dea to
9a78ac2
Compare
DrDet
approved these changes
Jun 6, 2025
astrophysik
approved these changes
Jun 9, 2025
9a78ac2 to
d1218ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Я долго думал как лучше сделать данную задачу. Сейчас у нас есть разделение на серверные логи
log_server_*, которые пишутся только с master процесса и "рантайм" логиphp_*. Идеологические они между собой ни как не связаны, кроме места где они пишутся в файл.При этом у серверных ошибок, уровень ошибок отрицательный, а у рантайм положительный. Благодаря этому, отсутствует пересечения ошибок с одинаковым типом. Можно считать, что это разные каналы для логов.
Чтобы никак не трогать текущий интерфейс
php_runtime_critical, я добавил новую функциюphp_runtime_critical, которая делает всё то же самое, но только пишет ошибку с серверным уровнем.Мысли вслух
По-хорошему, не должно быть никаких разделений на серверные и рантайм логи, всё идеологически должно быть в одном месте.