[k2] implement async stack#1320
Merged
Merged
Conversation
apolyakov
reviewed
May 22, 2025
66211a0 to
58e3191
Compare
apolyakov
reviewed
May 27, 2025
35847e8 to
f4477cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
This PR adds support for collecting async stack traces in runtime-light. Additionally, the implementation of
debug_backtracethat uses coroutine traces is also addedProblem
Basic usage of
backtracewith c++20 coroutines doesn't give enough information about execution. Common traces look like:Such traces don't show from which coroutine the coroutine requesting the stack trace was called. Moreover, at runtime, there should be the ability to reconstruct the sequence of coroutine calls not only for debugging purposes but also for language features, such as debug_backtrace, Exception::getTrace.
Solution
The solution is based on a similar approach from folly.
InstanceStatecontainsasync_stack_root, which acts as the equivalent of therbpregister for the coroutine stack. To maintain a pointer to the top coroutine frame inasync_stack_root, awaitables are usedasync_stack_watcher_t. High-level view can be found in the fileasync-stack.h.Result
With the help of the asynchronous stack, it is possible to obtain a correct trace of coroutines, for example:
Important aspects