change json_decode so that it accepts string_view instead of KPHP string#1398
Merged
apolyakov merged 2 commits intoSep 2, 2025
Merged
Conversation
apolyakov
added
runtime
apolyakov
force-pushed
the
apolyakov/make-json-decode-accept-string-view-insteadof-string
branch
from
792ec2b to
0fef56b
Compare
PetrShumilov
requested changes
Sep 1, 2025
PetrShumilov
approved these changes
Sep 2, 2025
apolyakov
deleted the
apolyakov/make-json-decode-accept-string-view-insteadof-string
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
json_decodeforces us to create unnecessary KPHP strings from time to time