Preparation step for You can now write TL serializers in PHP#1403
Merged
Conversation
apolyakov
reviewed
Sep 5, 2025
DrDet
reviewed
Sep 5, 2025
DrDet
approved these changes
Sep 9, 2025
DrDet
requested changes
Sep 9, 2025
Contributor
DrDet
left a comment
DrDet
left a comment
There was a problem hiding this comment.
Let's extract tl2php changes to separate PR and update it first, before merging changes with new abstract RpcFunction methods. Otherwise we can't compile code with old RpcFunction inheritors without new abstract methods implementation.
DrDet
approved these changes
Sep 19, 2025
Danil42Russia
added
refactoring
astrophysik
pushed a commit
that referenced
this pull request
Oct 14, 2025
astrophysik
pushed a commit
that referenced
this pull request
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR changes tl2php only (and generated code) to add stubs to
RpcFunctiondescendants (and RpcFunction.php, but only inside #ifndef KPHP).This MR adds no changes to runtime at all.
#1402