Skip to content

[k2] add KML support#1411

Merged
apolyakov merged 25 commits into
masterfrom
mkornaukhov03/kml-to-k2
Oct 15, 2025
Merged

[k2] add KML support#1411
apolyakov merged 25 commits into
masterfrom
mkornaukhov03/kml-to-k2

Conversation

@mkornaukhov
Copy link
Copy Markdown
Contributor

@mkornaukhov mkornaukhov commented Sep 18, 2025 •
edited
Loading

Previously, we've added a prediction kernel for xgboost and catboost, KML (see #983). It wasn't supported in runtime-light till the current pull request. It includes:

  • Move the main inference logic into runtime-common dir
  • Get rid of exceptions, using Rust-like Result approach
  • Gather required globals (mutable buffer, loaded model information) into context
  • Add php_info() function to write non-warning logs in runtime-common

@mkornaukhov mkornaukhov marked this pull request as ready for review September 19, 2025 12:32
@DrDet DrDet added this to the next milestone Sep 19, 2025
apolyakov
apolyakov requested changes Sep 22, 2025
View reviewed changes
Comment thread runtime-light/stdlib/kml/kml-instance-state.cpp Outdated
Comment thread runtime-common/stdlib/kml/kphp_ml_interface.cpp Outdated
PetrShumilov
PetrShumilov requested changes Sep 22, 2025
View reviewed changes
Comment thread runtime-common/stdlib/kml/kphp_ml_init.cpp Outdated
Comment thread runtime-common/stdlib/kml/kml-files-reader.cpp Outdated
Comment thread runtime-light/state/component-state.h Outdated
@mkornaukhov mkornaukhov added runtime Feature related to runtime k2 Affects compiler or runtime in K2 mode labels Sep 23, 2025
@apolyakov apolyakov force-pushed the mkornaukhov03/kml-to-k2 branch 4 times, most recently from 2419bf1 to a7826f7 Compare October 7, 2025 16:46
@apolyakov apolyakov changed the title KML in k2 [k2] add KML support Oct 7, 2025
@apolyakov apolyakov force-pushed the mkornaukhov03/kml-to-k2 branch from a7826f7 to eab5286 Compare October 7, 2025 16:49
astrophysik
astrophysik previously approved these changes Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@astrophysik astrophysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@apolyakov apolyakov requested a review from astrophysik October 14, 2025 12:44
PetrShumilov
PetrShumilov approved these changes Oct 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PetrShumilov PetrShumilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@apolyakov apolyakov merged commit 46e1761 into master Oct 15, 2025
7 checks passed
@apolyakov apolyakov deleted the mkornaukhov03/kml-to-k2 branch October 15, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetrShumilov PetrShumilov PetrShumilov approved these changes

@apolyakov apolyakov apolyakov approved these changes

@astrophysik astrophysik astrophysik approved these changes

@DrDet DrDet Awaiting requested review from DrDet

Assignees

@apolyakov apolyakov

Labels

k2 Affects compiler or runtime in K2 mode runtime Feature related to runtime

Projects

None yet

Milestone

25.11.2025

Development

Successfully merging this pull request may close these issues.

5 participants

@mkornaukhov @PetrShumilov @apolyakov @astrophysik @DrDet