Skip to content

move HyperLogLog functions to rumtime-common#1424

Merged
Shamzik merged 11 commits into
masterfrom
kshamazov/hyper_log_log
Oct 15, 2025
Merged

move HyperLogLog functions to rumtime-common#1424
Shamzik merged 11 commits into
masterfrom
kshamazov/hyper_log_log

Conversation

@Shamzik
Copy link
Copy Markdown
Contributor

@Shamzik Shamzik commented Oct 10, 2025

The goal is to support the following HyperLogLog functions in a light runtime:

  • vk_stats_hll_merge;
  • vk_stats_hll_count;
  • vk_stats_hll_create;
  • vk_stats_hll_add;
  • vk_stats_hll_pack;
  • vk_stats_hll_unpack;
  • vk_stats_hll_is_packed.

Also marked them as noexcept.

Shamzik
Shamzik commented Oct 10, 2025
View reviewed changes
Comment thread runtime/vkext_stats.cpp
@Shamzik Shamzik self-assigned this Oct 10, 2025
@Shamzik Shamzik added runtime Feature related to runtime missing functionality Missing PHP functions, classes, constants and etc k2 Affects compiler or runtime in K2 mode labels Oct 10, 2025
@Shamzik Shamzik added this to the next milestone Oct 10, 2025
apolyakov
apolyakov requested changes Oct 10, 2025
View reviewed changes
Comment thread runtime-common/stdlib/vkext/vkext-stats.cpp Outdated
@Shamzik Shamzik marked this pull request as ready for review October 13, 2025 11:46
@Shamzik Shamzik requested a review from apolyakov October 13, 2025 11:47
apolyakov
apolyakov previously approved these changes Oct 14, 2025
View reviewed changes
PetrShumilov
PetrShumilov requested changes Oct 14, 2025
View reviewed changes
Comment thread runtime-common/stdlib/vkext/vkext-stats.cpp
Comment thread runtime-common/stdlib/vkext/vkext-stats.cpp Outdated
Shamzik
Shamzik commented Oct 14, 2025
View reviewed changes
Comment thread runtime/vkext_stats.cpp
@Shamzik Shamzik requested a review from PetrShumilov October 14, 2025 13:20
PetrShumilov
PetrShumilov approved these changes Oct 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PetrShumilov PetrShumilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Shamzik Shamzik merged commit eeee03e into master Oct 15, 2025
7 of 8 checks passed
@Shamzik Shamzik deleted the kshamazov/hyper_log_log branch October 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetrShumilov PetrShumilov PetrShumilov approved these changes

@apolyakov apolyakov apolyakov approved these changes

Assignees

@Shamzik Shamzik

Labels

k2 Affects compiler or runtime in K2 mode missing functionality Missing PHP functions, classes, constants and etc runtime Feature related to runtime

Projects

None yet

Milestone

25.11.2025

Development

Successfully merging this pull request may close these issues.

3 participants

@Shamzik @PetrShumilov @apolyakov