[k2] pass const coroutine parameters by const ref where it's safe#1427
Merged
Conversation
apolyakov
added
compiler
apolyakov
force-pushed
the
apolyakov/k2-coro-args-by-reference
branch
from
ad33705 to
d11ca38
Compare
apolyakov
force-pushed
the
apolyakov/k2-coro-args-by-reference
branch
from
d11ca38 to
8fb5e82
Compare
astrophysik
approved these changes
Oct 14, 2025
Shamzik
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain scenarios, it is safe for coroutines to accept arguments by reference. This change allows the code generator to produce user-defined coroutines with reference parameters. The rationale behind this decision is that all await points are encapsulated within runtime functions, which are implemented with safety in mind.
This PR also updates several runtime functions to accept arguments by
const &. An additional// SAFETYcomment has been added to explain why this change is considered safe.