[k2] simplify scheduler API and RPC timeout normalization#1534
Merged
[k2] simplify scheduler API and RPC timeout normalization#1534
Conversation
Fix timeout handling issues and consolidate scheduler methods: - Add minimum 1ms step for timer resets to prevent platform issues with sub-millisecond timeouts in timer-handle.h - Simplify io_scheduler API by unifying methods: - schedule() now accepts optional duration for delayed execution - Remove yield() -> use schedule() - Remove yield_for() -> use schedule(duration) - Remove schedule_after() -> use schedule(duration) - All timeouts now use milliseconds consistently - Add kphp::concepts::duration concept for type-safe duration params - Update RPC timeout normalization to use std::clamp with explicit MIN_TIMEOUT (1ms), MAX_TIMEOUT (24h), DEFAULT_TIMEOUT (300ms) - Update all call sites to use the new unified API
apolyakov
changed the title
Shamzik
requested changes
Feb 25, 2026
Shamzik
previously approved these changes
Feb 25, 2026
astrophysik
reviewed
Feb 26, 2026
PetrShumilov
requested changes
Feb 26, 2026
Shamzik
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix timeout handling issues and consolidate scheduler methods:
Add minimum 1ms step for timer resets to prevent platform issues with sub-millisecond timeouts in timer-handle.h
Simplify io_scheduler API by unifying methods:
Add kphp::concepts::duration concept for type-safe duration params
Update RPC timeout normalization to use std::clamp with explicit MIN_TIMEOUT (1ms), MAX_TIMEOUT (24h), DEFAULT_TIMEOUT (300ms)
Do not use normalization timeout utility in sched_yield_sleep
Update all call sites to use the new unified API