Skip to content

[k2] increase timeout for phpt tests#1578

Merged
PetrShumilov merged 1 commit intomasterfrom
pshumilov/increase_timeout_for_phpt_tests
Mar 26, 2026
Merged

[k2] increase timeout for phpt tests#1578
PetrShumilov merged 1 commit intomasterfrom
pshumilov/increase_timeout_for_phpt_tests

Conversation

@PetrShumilov
Copy link
Contributor

@PetrShumilov PetrShumilov commented Mar 26, 2026

Previously, we didn't have timeout for phpt tests. After #1569 merging we have. In order to prevent flaky in k2 phpt tests need to increase timeout up to 600 sec.

Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov added this to the next milestone Mar 26, 2026
@PetrShumilov PetrShumilov self-assigned this Mar 26, 2026
@PetrShumilov PetrShumilov added small fix When it's not an huge enhancement CI/CD labels Mar 26, 2026
@apolyakov
Copy link
Contributor

In my opinion, this is not enough. It's fine to increase the timeout, but it still slows down all the CI runs. Moreover, as far as I see it may generate too much logs which may affect CI agents' disk space.

Alternatively we may have an option to run our CI with builtin functions coverage statistics enabled. It may be done on demand or, for example, on each merge to master.

Also, it may be better to have an option to customise task_hard_timeout

@PetrShumilov
Copy link
Contributor Author

In my opinion, this is not enough. It's fine to increase the timeout, but it still slows down all the CI runs. Moreover, as far as I see it may generate too much logs which may affect CI agents' disk space.

Alternatively we may have an option to run our CI with builtin functions coverage statistics enabled. It may be done on demand or, for example, on each merge to master.

Also, it may be better to have an option to customise task_hard_timeout

No related to this PR

@apolyakov
Copy link
Contributor

In my opinion, this is not enough. It's fine to increase the timeout, but it still slows down all the CI runs. Moreover, as far as I see it may generate too much logs which may affect CI agents' disk space.
Alternatively we may have an option to run our CI with builtin functions coverage statistics enabled. It may be done on demand or, for example, on each merge to master.
Also, it may be better to have an option to customise task_hard_timeout

No related to this PR

Why not? Should we think of this PR as of temporary solution?

@PetrShumilov
Copy link
Contributor Author

In my opinion, this is not enough. It's fine to increase the timeout, but it still slows down all the CI runs. Moreover, as far as I see it may generate too much logs which may affect CI agents' disk space.
Alternatively we may have an option to run our CI with builtin functions coverage statistics enabled. It may be done on demand or, for example, on each merge to master.
Also, it may be better to have an option to customise task_hard_timeout

No related to this PR

Why not? Should we think of this PR as of temporary solution?

ofc

@PetrShumilov PetrShumilov merged commit 1803e7b into master Mar 26, 2026
9 of 10 checks passed
@PetrShumilov PetrShumilov deleted the pshumilov/increase_timeout_for_phpt_tests branch March 26, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD small fix When it's not an huge enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants