Fix SIGSEGV double free (aka Unexpected memory piece)#1605
Merged
Conversation
apolyakov
reviewed
Apr 9, 2026
9b7e63c to
9cb1c50
Compare
- move callbacks to the very begin - move instance cache and confdata to the very end
9cb1c50 to
571bf57
Compare
denisichh
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips PR reorders runtime subsytems deinitializations to prevent SIGSEGV and "Unexpected memory piece" errors.
The main reason - wrong time of freeing Confdata and InstanceCache.
They MUST be freed at the very end. IC and CD call
force_destroy()on runtime primitives inside, which forcibly sets refcnt to zero. It leads to double free if someone tries to destroy such primitives after it (e.g. in case of destroying saved callbacks capturing objects from InstanceCache or Confdata).Minimal reproducer with
register_kphp_on_oom_callback: