Skip to content

add alloc_align into kphp::memory::script#1630

Merged
PetrShumilov merged 3 commits into
masterfrom
pshumilov/add_script_memory_alloc_align
May 20, 2026
Merged

add alloc_align into kphp::memory::script#1630
PetrShumilov merged 3 commits into
masterfrom
pshumilov/add_script_memory_alloc_align

Conversation

@PetrShumilov
Copy link
Copy Markdown
Contributor

@PetrShumilov PetrShumilov commented May 20, 2026

  • Redesigned layout of block's header
    • 48 bit for block's size
    • 16 bit for block's base offset
  • Moved alloc, free and realloc into new control block layout

@PetrShumilov PetrShumilov added this to the next milestone May 20, 2026
@PetrShumilov PetrShumilov self-assigned this May 20, 2026
@PetrShumilov PetrShumilov added runtime Feature related to runtime k2 Affects compiler or runtime in K2 mode kphp Affects compiler or runtime in default mode (not K2) labels May 20, 2026
@PetrShumilov PetrShumilov force-pushed the pshumilov/add_script_memory_alloc_align branch 2 times, most recently from 1721dd8 to ac153a8 Compare May 20, 2026 09:47
@PetrShumilov
Add alloc_align
2bc4751 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/add_script_memory_alloc_align branch from ac153a8 to 2bc4751 Compare May 20, 2026 11:14
@PetrShumilov
Fix code style
1042232 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/add_script_memory_alloc_align branch from 01f946c to 1042232 Compare May 20, 2026 12:25
apolyakov
apolyakov requested changes May 20, 2026
View reviewed changes
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
Comment thread runtime-common/core/allocator/script-malloc-interface.h Outdated
@PetrShumilov PetrShumilov force-pushed the pshumilov/add_script_memory_alloc_align branch from 073550a to f891bb5 Compare May 20, 2026 14:15
@PetrShumilov
Fix code style
9a0d1db 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov PetrShumilov force-pushed the pshumilov/add_script_memory_alloc_align branch from f891bb5 to 9a0d1db Compare May 20, 2026 14:17
apolyakov
apolyakov approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@apolyakov apolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PetrShumilov PetrShumilov merged commit 81c94fe into master May 20, 2026
7 checks passed
@PetrShumilov PetrShumilov deleted the pshumilov/add_script_memory_alloc_align branch May 20, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolyakov apolyakov apolyakov approved these changes

@astrophysik astrophysik Awaiting requested review from astrophysik

Assignees

@PetrShumilov PetrShumilov

Labels

k2 Affects compiler or runtime in K2 mode kphp Affects compiler or runtime in default mode (not K2) runtime Feature related to runtime

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

2 participants

@PetrShumilov @apolyakov