[k2] fix coro frame alignment#1631
Merged
Merged
Conversation
7e42ece to
1f07398
Compare
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
04e3b00 to
3219b77
Compare
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
astrophysik
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
clang-18and-O2member initialization of record types may be lowered to SIMD instructions. For example, member zero initialization forpromise_base(part of coroutine frame) may looks like:According to the
x86specification, the destination operand ofvmovapsmust be aligned to 16, 32, or 64 bytes, depending on the register width. However,-fcoro-aligned-allocationoption, clang doesn't invoke overload ofoperator newwith alignment parameter;is failed with
SIGSEGVwhen-O2is enabled.