Skip to content

Shutdown functions on timeout: improvements#847

Merged
DrDet merged 6 commits intomasterfrom
dvaksman/jw-shutdown-timeout
Jun 8, 2023
Merged

Shutdown functions on timeout: improvements#847
DrDet merged 6 commits intomasterfrom
dvaksman/jw-shutdown-timeout

Conversation

@DrDet
Copy link
Copy Markdown
Contributor

@DrDet DrDet commented Jun 8, 2023 •
edited
Loading

  • Don't delay timeout if there's no shutdown functions
  • Add option for hard-timeout to turn it off in case of emergency (by default 1 sec is enabled)
  • Never delay timeout in job workers because it's critical

@DrDet DrDet added this to the next milestone Jun 8, 2023
@DrDet DrDet requested a review from astrophysik June 8, 2023 14:53
troy4eg
troy4eg previously approved these changes Jun 8, 2023
View reviewed changes
astrophysik
astrophysik previously approved these changes Jun 8, 2023
View reviewed changes
@DrDet DrDet merged commit dca34e9 into master Jun 8, 2023
@DrDet DrDet deleted the dvaksman/jw-shutdown-timeout branch June 8, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@troy4eg troy4eg troy4eg approved these changes

@astrophysik astrophysik astrophysik left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

09.06.2023

Development

Successfully merging this pull request may close these issues.

3 participants

@DrDet @troy4eg @astrophysik