introduce an intention to add @kphp-immutable-class annotation#67
Merged
introduce an intention to add @kphp-immutable-class annotation#67
@kphp-immutable-class annotation#67Conversation
vldF
force-pushed
the
vldf/add-kphp-immutable-class-intention
branch
2 times, most recently
from
d8b8f52 to
19aeb7c
Compare
Danil42Russia
changed the title
@kphp-immutable-class intention
src/main/resources/intentionDescriptions/AddImmutableClassAnnotationIntention/description.html
Outdated
Show resolved
Hide resolved
Merged
vldF
changed the title
@kphp-immutable-class intention
vldF
force-pushed
the
vldf/add-kphp-immutable-class-intention
branch
from
320d855 to
2da4b8c
Compare
i582
reviewed
Jul 24, 2025
src/test/fixtures/kphp_intentions/immutable_class_intention-7.fixture.php
Outdated
Show resolved
Hide resolved
i582
reviewed
Jul 24, 2025
src/main/kotlin/com/vk/kphpstorm/intentions/AddImmutableClassAnnotationIntention.kt
Outdated
Show resolved
Hide resolved
i582
reviewed
Jul 24, 2025
i582
reviewed
Jul 24, 2025
src/main/kotlin/com/vk/kphpstorm/inspections/helpers/PhpDocPsiBuilder.kt
Show resolved
Hide resolved
src/main/kotlin/com/vk/kphpstorm/intentions/AddImmutableClassAnnotationIntention.kt
Outdated
Show resolved
Hide resolved
vldF
changed the title
@kphp-immutable-class' intention
Danil42Russia
approved these changes
Jul 28, 2025
vldF
changed the title
@kphp-immutable-class' intention@kphp-immutable-class annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented the simplest ever mutability analysis. Probably, we can change its scope to the global one, however, it can lead to some performance issues
Also, the new testing function
assertNoIntentionwas added to the project.