Skip to content

Preview on iPad with text description #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akaDuality merged 43 commits into from
Jan 14, 2024
Merged

Preview on iPad with text description #291

akaDuality merged 43 commits into from
Jan 14, 2024

Conversation

@akaDuality
Copy link
Collaborator

@akaDuality akaDuality commented Oct 24, 2023 •
edited
Loading

Closes #279

  • Improve: add StateController that depends on size classes
    • Draw canvas when there is a known trait. The new API is backported to iOS 13
    • Check state behavior at iOS 16
  • Remove jumping animation when Preview's elements have different width
  • Add a presentation button to separate drawing and presentation modes like on macOS
  • Navigation bar in translucent on iPad
  • Publish changes when text loses focus (and add UI-tests)
  • Add image-cache to speed up image loading and test by performance. An image loads whenever the artboard publisher has been changed
  • Update elements trait after selection (check by elements color)
    • Add UI-test for that: expose rectangles for accessiblitiy to use it in UI-tests)

@akaDuality akaDuality added the enhancement New feature or request label Oct 24, 2023
@akaDuality akaDuality added this to the Presentation mode milestone Oct 24, 2023
@akaDuality akaDuality self-assigned this Oct 24, 2023
@akaDuality akaDuality marked this pull request as draft October 24, 2023 14:01
@AgapovOne
Copy link
Collaborator

AgapovOne commented Oct 26, 2023 •
edited
Loading

I pushed a fix for building, changed decision from phone to horizontalSizeClass.

But it still doesn't work for OTT samples

Details

Simulator Screenshot - iPad Pro (11-inch) (4th generation) - 2023-10-26 at 11 54 49

@akaDuality akaDuality modified the milestones: Presentation mode, Someday Nov 6, 2023
@akaDuality akaDuality mentioned this pull request Jan 7, 2024
Open
17 tasks
@akaDuality
Merge branch 'develop' into iPadPreview
c32a245 
# Conflicts:
#	Shared/Package.swift
#	Shared/Sources/Presentation/PresentationModel.swift
#	Shared/Sources/Presentation/PresentationView.swift
#	VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/Main/PreviewMainViewController.swift
#	VoiceOver Preview/VoiceOver Preview.xcodeproj/project.pbxproj
#	VoiceOver Preview/VoiceOver Preview/SceneDelegate.swift
@akaDuality
Restore PresentationModel
64ecded
@akaDuality
Remove duplicated target
213eac0
@akaDuality
Fix build
9e1d12b
@akaDuality akaDuality changed the base branch from main to develop January 8, 2024 00:06
akaDuality
akaDuality commented Jan 8, 2024
View reviewed changes
@akaDuality akaDuality marked this pull request as ready for review January 8, 2024 00:12
@akaDuality akaDuality marked this pull request as draft January 8, 2024 00:12
@akaDuality akaDuality marked this pull request as ready for review January 13, 2024 16:26
drucelweisse
drucelweisse requested changes Jan 14, 2024
View reviewed changes
@akaDuality akaDuality merged commit cda441d into develop Jan 14, 2024
@akaDuality akaDuality deleted the iPadPreview branch January 14, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drucelweisse drucelweisse drucelweisse requested changes

@AgapovOne AgapovOne Awaiting requested review from AgapovOne

Assignees

@akaDuality akaDuality

Labels

enhancement New feature or request

Projects

Development of VoiceOver Designer
Status: Done

Milestone

Someday

Development

Successfully merging this pull request may close these issues.

Add presentation mode to iPad?

4 participants

@akaDuality @AgapovOne @drucelweisse